mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 07:13:34 +00:00
media: i2c: st-mipid02: correct format propagation
commitb33cb0cbe2
upstream. Use a copy of the struct v4l2_subdev_format when propagating format from the sink to source pad in order to avoid impacting the sink format returned to the application. Thanks to Jacopo Mondi for pointing the issue. Fixes:6c01e6f3f2
("media: st-mipid02: Propagate format from sink to source pad") Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> Cc: stable@vger.kernel.org Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
095cb607f1
commit
9399d61bf5
1 changed files with 7 additions and 2 deletions
|
@ -770,6 +770,7 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd,
|
|||
struct v4l2_subdev_format *format)
|
||||
{
|
||||
struct mipid02_dev *bridge = to_mipid02_dev(sd);
|
||||
struct v4l2_subdev_format source_fmt;
|
||||
struct v4l2_mbus_framefmt *fmt;
|
||||
|
||||
format->format.code = get_fmt_code(format->format.code);
|
||||
|
@ -781,8 +782,12 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd,
|
|||
|
||||
*fmt = format->format;
|
||||
|
||||
/* Propagate the format change to the source pad */
|
||||
mipid02_set_fmt_source(sd, sd_state, format);
|
||||
/*
|
||||
* Propagate the format change to the source pad, taking
|
||||
* care not to update the format pointer given back to user
|
||||
*/
|
||||
source_fmt = *format;
|
||||
mipid02_set_fmt_source(sd, sd_state, &source_fmt);
|
||||
}
|
||||
|
||||
static int mipid02_set_fmt(struct v4l2_subdev *sd,
|
||||
|
|
Loading…
Reference in a new issue