mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 07:04:44 +00:00
octeontx2-pf: Fix reset_task bugs
Two bugs exist in the code related to reset_task
in PF driver one is the missing protection
against network stack ndo_open and ndo_close.
Other one is the missing cancel_work.
This patch fixes those problems.
Fixes: 4ff7d1488a
("octeontx2-pf: Error handling support")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3cab8c6552
commit
948a66338f
1 changed files with 3 additions and 0 deletions
|
@ -1730,10 +1730,12 @@ static void otx2_reset_task(struct work_struct *work)
|
|||
if (!netif_running(pf->netdev))
|
||||
return;
|
||||
|
||||
rtnl_lock();
|
||||
otx2_stop(pf->netdev);
|
||||
pf->reset_count++;
|
||||
otx2_open(pf->netdev);
|
||||
netif_trans_update(pf->netdev);
|
||||
rtnl_unlock();
|
||||
}
|
||||
|
||||
static const struct net_device_ops otx2_netdev_ops = {
|
||||
|
@ -2111,6 +2113,7 @@ static void otx2_remove(struct pci_dev *pdev)
|
|||
|
||||
pf = netdev_priv(netdev);
|
||||
|
||||
cancel_work_sync(&pf->reset_task);
|
||||
/* Disable link notifications */
|
||||
otx2_cgx_config_linkevents(pf, false);
|
||||
|
||||
|
|
Loading…
Reference in a new issue