mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 23:27:06 +00:00
Code Issues Releases Wiki Activity

greybus: light: Initialize mutex before using it

Browse source 
Light protocol driver is suffering from the same issue that was fixed in
camera driver earlier (commit a7c3b0c3c8da).

Big cleanup function is used instead of fine grained control in the
error path, and in one of the cases the mutex was found uninitialized
and so the oops seen in SW-6752.

Initialize the mutex before any code can access it.

Compile tested only.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-06-29 13:42:26 -07:00 committed by Greg Kroah-Hartman
parent 2aae92bdc2
commit 957ccca08a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/greybus/light.c
View file

@ -1221,6 +1221,8 @@ static int gb_lights_probe(struct gb_bundle *bundle,
if (!glights)
return -ENOMEM;
mutex_init(&glights->lights_lock);
connection = gb_connection_create(bundle, le16_to_cpu(cport_desc->id),
gb_lights_request_handler);
if (IS_ERR(connection)) {
@ -1231,8 +1233,6 @@ static int gb_lights_probe(struct gb_bundle *bundle,
glights->connection = connection;
gb_connection_set_data(connection, glights);
mutex_init(&glights->lights_lock);
greybus_set_drvdata(bundle, glights);
/* We aren't ready to receive an incoming request yet */