mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-22 08:49:45 +00:00
Code Issues Releases Wiki Activity

RDMA/bnxt: Fix structure layout for bnxt_re_pd_resp

Browse source 
What is going on here is a bit subtle, in the kernel there is no
problem because the struct is copied using copy_from_user, so it
can safely have an 8 byte alignment, however in userspace it must
be constructed by concatenation with the ib_uverbs_alloc_pd_resp
struct. This is due to the required memory layout to execute the
command.

Since ibv_uverbs_alloc_pd_resp is only 4 bytes long, this causes
misalignment, and the user space will experience an unexpected padding.
Currently it works around this via pointer maths.

Make everything more robust by having the compiler reduce the alignment
of the struct to 4. The userspace has assertions to ensure this
works properly in all situations.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Jason Gunthorpe 2018-03-15 21:18:14 -06:00
parent 7672ed33c4
commit 958d2c1ba3
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
include/uapi/rdma/bnxt_re-abi.h
View file

@ -53,11 +53,16 @@ struct bnxt_re_uctx_resp {
__u32 rsvd;
};
/*
* This struct is placed after the ib_uverbs_alloc_pd_resp struct, which is
* not 8 byted aligned. To avoid undesired padding in various cases we have to
* set this struct to packed.
*/
struct bnxt_re_pd_resp {
__u32 pdid;
__u32 dpi;
__u64 dbr;
};
} __attribute__((packed, aligned(4)));
struct bnxt_re_cq_req {
__u64 cq_va;