mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 13:22:57 +00:00
iio: core: fix memleak in iio_device_register_sysfs
When iio_device_register_sysfs_group() fails, we should
free iio_dev_opaque->chan_attr_group.attrs to prevent
potential memleak.
Fixes: 32f171724e
("iio: core: rework iio device group creation")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20231208073119.29283-1-dinghao.liu@zju.edu.cn
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
parent
6613476e22
commit
95a0d596bb
1 changed files with 4 additions and 1 deletions
|
@ -1584,10 +1584,13 @@ static int iio_device_register_sysfs(struct iio_dev *indio_dev)
|
|||
ret = iio_device_register_sysfs_group(indio_dev,
|
||||
&iio_dev_opaque->chan_attr_group);
|
||||
if (ret)
|
||||
goto error_clear_attrs;
|
||||
goto error_free_chan_attrs;
|
||||
|
||||
return 0;
|
||||
|
||||
error_free_chan_attrs:
|
||||
kfree(iio_dev_opaque->chan_attr_group.attrs);
|
||||
iio_dev_opaque->chan_attr_group.attrs = NULL;
|
||||
error_clear_attrs:
|
||||
iio_free_chan_devattr_list(&iio_dev_opaque->channel_attr_list);
|
||||
|
||||
|
|
Loading…
Reference in a new issue