mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
net: arc_emac: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. And using dev_err_probe() can reduce code size, and simplify the code. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
5706383b30
commit
95b5fc03c1
1 changed files with 4 additions and 5 deletions
|
@ -151,10 +151,9 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
|
|||
data->reset_gpio = devm_gpiod_get_optional(priv->dev, "phy-reset",
|
||||
GPIOD_OUT_LOW);
|
||||
if (IS_ERR(data->reset_gpio)) {
|
||||
error = PTR_ERR(data->reset_gpio);
|
||||
dev_err(priv->dev, "Failed to request gpio: %d\n", error);
|
||||
mdiobus_free(bus);
|
||||
return error;
|
||||
return dev_err_probe(priv->dev, PTR_ERR(data->reset_gpio),
|
||||
"Failed to request gpio\n");
|
||||
}
|
||||
|
||||
of_property_read_u32(np, "phy-reset-duration", &data->msec);
|
||||
|
@ -166,9 +165,9 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
|
|||
|
||||
error = of_mdiobus_register(bus, priv->dev->of_node);
|
||||
if (error) {
|
||||
dev_err(priv->dev, "cannot register MDIO bus %s\n", bus->name);
|
||||
mdiobus_free(bus);
|
||||
return error;
|
||||
return dev_err_probe(priv->dev, error,
|
||||
"cannot register MDIO bus %s\n", bus->name);
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue