mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
staging: vt6655: vt6655_init_info function must be void type
this is because it doesn't fail anywhere and returning a value from it will be completely unnecesary. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
cfd1fc1f5f
commit
960cf81187
1 changed files with 3 additions and 7 deletions
|
@ -290,7 +290,7 @@ DEFINE_PCI_DEVICE_TABLE(vt6655_pci_id_table) = {
|
|||
|
||||
|
||||
static int vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent);
|
||||
static bool vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO);
|
||||
static void vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO);
|
||||
static void device_free_info(PSDevice pDevice);
|
||||
static bool device_get_pci_info(PSDevice, struct pci_dev* pcid);
|
||||
static void device_print_info(PSDevice pDevice);
|
||||
|
@ -935,9 +935,7 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent)
|
|||
bFirst=false;
|
||||
}
|
||||
|
||||
if (!vt6655_init_info(pcid, &pDevice, pChip_info)) {
|
||||
return -ENOMEM;
|
||||
}
|
||||
vt6655_init_info(pcid, &pDevice, pChip_info);
|
||||
pDevice->dev = dev;
|
||||
pDevice->next_module = root_device_dev;
|
||||
root_device_dev = dev;
|
||||
|
@ -1101,7 +1099,7 @@ static void device_print_info(PSDevice pDevice)
|
|||
|
||||
}
|
||||
|
||||
static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
|
||||
static void __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
|
||||
PCHIP_INFO pChip_info) {
|
||||
|
||||
PSDevice p;
|
||||
|
@ -1125,8 +1123,6 @@ static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
|
|||
(*ppDevice)->multicast_limit =32;
|
||||
|
||||
spin_lock_init(&((*ppDevice)->lock));
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
static bool device_get_pci_info(PSDevice pDevice, struct pci_dev* pcid) {
|
||||
|
|
Loading…
Reference in a new issue