mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-20 14:16:02 +00:00
Code Issues Releases Wiki Activity

staging: vc04_services: Drop unused parameters from vchi_connect()

Browse source 
Remove two parameters which are never used and all where all callers
just pass in dummy values anyway.

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tuomas Tynkkynen 2018-10-04 12:37:46 +03:00 committed by Greg Kroah-Hartman
parent 5bc4ab85ea
commit 96abfeca68
4 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
View file

@ -183,7 +183,7 @@ int bcm2835_new_vchi_ctx(struct device *dev, struct bcm2835_vchi_ctx *vchi_ctx)
return -EIO; return -EIO;
} }
ret = vchi_connect(NULL, 0, vchi_ctx->vchi_instance); ret = vchi_connect(vchi_ctx->vchi_instance);
if (ret) { if (ret) {
dev_dbg(dev, "failed to connect VCHI instance (ret=%d)\n", dev_dbg(dev, "failed to connect VCHI instance (ret=%d)\n",
ret); ret);

2
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
View file

@ -1831,7 +1831,7 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance)
return -EIO; return -EIO;
} }
status = vchi_connect(NULL, 0, vchi_instance); status = vchi_connect(vchi_instance);
if (status) { if (status) {
pr_err("Failed to connect VCHI instance (status=%d)\n", status); pr_err("Failed to connect VCHI instance (status=%d)\n", status);
return -EIO; return -EIO;

4
drivers/staging/vc04_services/interface/vchi/vchi.h
View file

@ -100,9 +100,7 @@ extern int32_t vchi_initialise(VCHI_INSTANCE_T *instance_handle);
extern int32_t vchi_exit(void); extern int32_t vchi_exit(void);
extern int32_t vchi_connect(VCHI_CONNECTION_T **connections, extern int32_t vchi_connect(VCHI_INSTANCE_T instance_handle);
const uint32_t num_connections,
VCHI_INSTANCE_T instance_handle);
//When this is called, ensure that all services have no data pending. //When this is called, ensure that all services have no data pending.
//Bulk transfers can remain 'queued' //Bulk transfers can remain 'queued'

11
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
View file

@ -490,9 +490,7 @@ EXPORT_SYMBOL(vchi_initialise);
/*********************************************************** /***********************************************************
* Name: vchi_connect * Name: vchi_connect
* *
* Arguments: VCHI_CONNECTION_T **connections * Arguments: VCHI_INSTANCE_T instance_handle
* const uint32_t num_connections
* VCHI_INSTANCE_T instance_handle)
* *
* Description: Starts the command service on each connection, * Description: Starts the command service on each connection,
* causing INIT messages to be pinged back and forth * causing INIT messages to be pinged back and forth
@ -500,15 +498,10 @@ EXPORT_SYMBOL(vchi_initialise);
* Returns: 0 if successful, failure otherwise * Returns: 0 if successful, failure otherwise
* *
***********************************************************/ ***********************************************************/
int32_t vchi_connect(VCHI_CONNECTION_T **connections, int32_t vchi_connect(VCHI_INSTANCE_T instance_handle)
const uint32_t num_connections,
VCHI_INSTANCE_T instance_handle)
{ {
VCHIQ_INSTANCE_T instance = (VCHIQ_INSTANCE_T)instance_handle; VCHIQ_INSTANCE_T instance = (VCHIQ_INSTANCE_T)instance_handle;
(void)connections;
(void)num_connections;
return vchiq_connect(instance); return vchiq_connect(instance);
} }
EXPORT_SYMBOL(vchi_connect); EXPORT_SYMBOL(vchi_connect);