mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 21:03:32 +00:00
KVM: x86: Disallow guest CPUID lookups when IRQs are disabled
Now that KVM has a framework for caching guest CPUID feature flags, add a "rule" that IRQs must be enabled when doing guest CPUID lookups, and enforce the rule via a lockdep assertion. CPUID lookups are slow, and within KVM, IRQs are only ever disabled in hot paths, e.g. the core run loop, fast page fault handling, etc. I.e. querying guest CPUID with IRQs disabled, especially in the run loop, should be avoided. Link: https://lore.kernel.org/r/20230815203653.519297-16-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
This commit is contained in:
parent
ee785c870d
commit
9717efbe5b
1 changed files with 13 additions and 0 deletions
|
@ -11,6 +11,7 @@
|
|||
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
||||
|
||||
#include <linux/kvm_host.h>
|
||||
#include "linux/lockdep.h"
|
||||
#include <linux/export.h>
|
||||
#include <linux/vmalloc.h>
|
||||
#include <linux/uaccess.h>
|
||||
|
@ -84,6 +85,18 @@ static inline struct kvm_cpuid_entry2 *cpuid_entry2_find(
|
|||
struct kvm_cpuid_entry2 *e;
|
||||
int i;
|
||||
|
||||
/*
|
||||
* KVM has a semi-arbitrary rule that querying the guest's CPUID model
|
||||
* with IRQs disabled is disallowed. The CPUID model can legitimately
|
||||
* have over one hundred entries, i.e. the lookup is slow, and IRQs are
|
||||
* typically disabled in KVM only when KVM is in a performance critical
|
||||
* path, e.g. the core VM-Enter/VM-Exit run loop. Nothing will break
|
||||
* if this rule is violated, this assertion is purely to flag potential
|
||||
* performance issues. If this fires, consider moving the lookup out
|
||||
* of the hotpath, e.g. by caching information during CPUID updates.
|
||||
*/
|
||||
lockdep_assert_irqs_enabled();
|
||||
|
||||
for (i = 0; i < nent; i++) {
|
||||
e = &entries[i];
|
||||
|
||||
|
|
Loading…
Reference in a new issue