mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-28 11:49:32 +00:00
Code Issues Releases Wiki Activity

kcsan: Fold panic() call into print_report()

Browse source 
So that we can add more callers of print_report(), lets fold the panic()
call into print_report() so the caller doesn't have to handle this
explicitly.

There should be no functional change as a result of this patch.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
This commit is contained in:
Mark Rutland 2021-04-14 13:28:20 +02:00 committed by Paul E. McKenney
parent 95f7524d7f
commit 97aa6139e1
1 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
kernel/kcsan/report.c
View file

@ -325,10 +325,7 @@ static void print_verbose_info(struct task_struct *task)
print_irqtrace_events(task); print_irqtrace_events(task);
} }
/* static void print_report(enum kcsan_value_change value_change,
* Returns true if a report was generated, false otherwise.
*/
static bool print_report(enum kcsan_value_change value_change,
enum kcsan_report_type type, enum kcsan_report_type type,
const struct access_info *ai, const struct access_info *ai,
const struct other_info *other_info) const struct other_info *other_info)
@ -344,7 +341,7 @@ static bool print_report(enum kcsan_value_change value_change,
* Must check report filter rules before starting to print. * Must check report filter rules before starting to print.
*/ */
if (skip_report(KCSAN_VALUE_CHANGE_TRUE, stack_entries[skipnr])) if (skip_report(KCSAN_VALUE_CHANGE_TRUE, stack_entries[skipnr]))
return false; return;
if (type == KCSAN_REPORT_RACE_SIGNAL) { if (type == KCSAN_REPORT_RACE_SIGNAL) {
other_skipnr = get_stack_skipnr(other_info->stack_entries, other_skipnr = get_stack_skipnr(other_info->stack_entries,
@ -353,11 +350,11 @@ static bool print_report(enum kcsan_value_change value_change,
/* @value_change is only known for the other thread */ /* @value_change is only known for the other thread */
if (skip_report(value_change, other_frame)) if (skip_report(value_change, other_frame))
return false; return;
} }
if (rate_limit_report(this_frame, other_frame)) if (rate_limit_report(this_frame, other_frame))
return false; return;
/* Print report header. */ /* Print report header. */
pr_err("==================================================================\n"); pr_err("==================================================================\n");
@ -431,7 +428,8 @@ static bool print_report(enum kcsan_value_change value_change,
dump_stack_print_info(KERN_DEFAULT); dump_stack_print_info(KERN_DEFAULT);
pr_err("==================================================================\n"); pr_err("==================================================================\n");
return true; if (panic_on_warn)
panic("panic_on_warn set ...\n");
} }
static void release_report(unsigned long *flags, struct other_info *other_info) static void release_report(unsigned long *flags, struct other_info *other_info)
@ -628,11 +626,8 @@ static void kcsan_report(const volatile void *ptr, size_t size, int access_type,
* either TRUE or MAYBE. In case of MAYBE, further filtering may * either TRUE or MAYBE. In case of MAYBE, further filtering may
* be done once we know the full stack trace in print_report(). * be done once we know the full stack trace in print_report().
*/ */
bool reported = value_change != KCSAN_VALUE_CHANGE_FALSE && if (value_change != KCSAN_VALUE_CHANGE_FALSE)
print_report(value_change, type, &ai, other_info); print_report(value_change, type, &ai, other_info);
if (reported && panic_on_warn)
panic("panic_on_warn set ...\n");
release_report(&flags, other_info); release_report(&flags, other_info);
} }