mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-28 21:33:52 +00:00
Code Issues Releases Wiki Activity

power: supply: cw2015: Fix potential null-ptr-deref in cw_bat_probe()

Browse source 
cw_bat_probe() calls create_singlethread_workqueue() and not checked the
ret value, which may return NULL. And a null-ptr-deref may happen:

cw_bat_probe()
    create_singlethread_workqueue() # failed, cw_bat->wq is NULL
    queue_delayed_work()
        queue_delayed_work_on()
            __queue_delayed_work()  # warning here, but continue
                __queue_work()      # access wq->flags, null-ptr-deref

Check the ret value and return -ENOMEM if it is NULL.

Fixes: b4c7715c10 ("power: supply: add CellWise cw2015 fuel gauge driver")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
Shang XiaoJing 2022-11-17 10:45:58 +08:00 committed by Sebastian Reichel
parent 955bee204f
commit 97f2b4ddb0
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/power/supply/cw2015_battery.c
View file

@ -699,6 +699,9 @@ static int cw_bat_probe(struct i2c_client *client)
} }
cw_bat->battery_workqueue = create_singlethread_workqueue("rk_battery"); cw_bat->battery_workqueue = create_singlethread_workqueue("rk_battery");
if (!cw_bat->battery_workqueue)
return -ENOMEM;
devm_delayed_work_autocancel(&client->dev, devm_delayed_work_autocancel(&client->dev,
&cw_bat->battery_delay_work, cw_bat_work); &cw_bat->battery_delay_work, cw_bat_work);
queue_delayed_work(cw_bat->battery_workqueue, queue_delayed_work(cw_bat->battery_workqueue,