mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
[media] exynos-gsc: Don't use mutex_lock_interruptible() in device release()
Use uninterruptible mutex_lock in the release() file op to make sure all resources are properly freed when a process is being terminated. Returning -ERESTARTSYS has no effect for a terminating process and this may cause driver resources not to be released. Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
ddc43d6dc7
commit
9868018045
1 changed files with 1 additions and 2 deletions
|
@ -657,8 +657,7 @@ static int gsc_m2m_release(struct file *file)
|
|||
pr_debug("pid: %d, state: 0x%lx, refcnt= %d",
|
||||
task_pid_nr(current), gsc->state, gsc->m2m.refcnt);
|
||||
|
||||
if (mutex_lock_interruptible(&gsc->lock))
|
||||
return -ERESTARTSYS;
|
||||
mutex_lock(&gsc->lock);
|
||||
|
||||
v4l2_m2m_ctx_release(ctx->m2m_ctx);
|
||||
gsc_ctrls_delete(ctx);
|
||||
|
|
Loading…
Reference in a new issue