mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-05 18:39:59 +00:00
Code Issues Releases Wiki Activity

USB: ezusb: remove dependancy on usb_serial

Browse source 
This patch removes the dependency on the usb_serial interface and names
some magic constants

Signed-off-by: René Bürgel <rene.buergel@sohard.de>
--
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rene Buergel 2012-09-13 22:14:38 +02:00 committed by Greg Kroah-Hartman
parent 8321652ae2
commit 99495c7061
5 changed files with 35 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
drivers/usb/serial/ezusb.c
View file

@ -9,24 +9,24 @@
*/ */
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/tty.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/usb.h> #include <linux/usb.h>
#include <linux/usb/serial.h>
/* EZ-USB Control and Status Register. Bit 0 controls 8051 reset */ /* EZ-USB Control and Status Register. Bit 0 controls 8051 reset */
#define CPUCS_REG 0x7F92 #define CPUCS_REG 0x7F92
int ezusb_writememory(struct usb_serial *serial, int address, /* Command for writing to internal memory */
#define WRITE_INT_RAM 0xA0
int ezusb_writememory(struct usb_device *dev, int address,
unsigned char *data, int length, __u8 request) unsigned char *data, int length, __u8 request)
{ {
int result; int result;
unsigned char *transfer_buffer; unsigned char *transfer_buffer;
if (!serial->dev) { if (!dev) {
printk(KERN_ERR "ezusb: %s - no physical device present, " printk(KERN_ERR "ezusb: %s - no physical device present, "
"failing.\n", __func__); "failing.\n", __func__);
return -ENODEV; return -ENODEV;
@ -34,25 +34,25 @@ int ezusb_writememory(struct usb_serial *serial, int address,
transfer_buffer = kmemdup(data, length, GFP_KERNEL); transfer_buffer = kmemdup(data, length, GFP_KERNEL);
if (!transfer_buffer) { if (!transfer_buffer) {
dev_err(&serial->dev->dev, "%s - kmalloc(%d) failed.\n", dev_err(&dev->dev, "%s - kmalloc(%d) failed.\n",
__func__, length); __func__, length);
return -ENOMEM; return -ENOMEM;
} }
result = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), result = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), request,
request, 0x40, address, 0, transfer_buffer, length, 3000); USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
address, 0, transfer_buffer, length, 3000);
kfree(transfer_buffer); kfree(transfer_buffer);
return result; return result;
} }
EXPORT_SYMBOL_GPL(ezusb_writememory); EXPORT_SYMBOL_GPL(ezusb_writememory);
int ezusb_set_reset(struct usb_serial *serial, unsigned char reset_bit) int ezusb_set_reset(struct usb_device *dev, unsigned char reset_bit)
{ {
int response; int response = ezusb_writememory(dev, CPUCS_REG, &reset_bit, 1, WRITE_INT_RAM);
response = ezusb_writememory(serial, CPUCS_REG, &reset_bit, 1, 0xa0);
if (response < 0) if (response < 0)
dev_err(&serial->dev->dev, "%s- %d failed\n", dev_err(&dev->dev, "%s-%d failed: %d\n",
__func__, reset_bit); __func__, reset_bit, response);
return response; return response;
} }
EXPORT_SYMBOL_GPL(ezusb_set_reset); EXPORT_SYMBOL_GPL(ezusb_set_reset);

6
drivers/usb/serial/keyspan.c
View file

@ -1241,12 +1241,12 @@ static int keyspan_fake_startup(struct usb_serial *serial)
dbg("Uploading Keyspan %s firmware.", fw_name); dbg("Uploading Keyspan %s firmware.", fw_name);
/* download the firmware image */ /* download the firmware image */
response = ezusb_set_reset(serial, 1); response = ezusb_set_reset(serial->dev, 1);
record = (const struct ihex_binrec *)fw->data; record = (const struct ihex_binrec *)fw->data;
while (record) { while (record) {
response = ezusb_writememory(serial, be32_to_cpu(record->addr), response = ezusb_writememory(serial->dev, be32_to_cpu(record->addr),
(unsigned char *)record->data, (unsigned char *)record->data,
be16_to_cpu(record->len), 0xa0); be16_to_cpu(record->len), 0xa0);
if (response < 0) { if (response < 0) {
@ -1260,7 +1260,7 @@ static int keyspan_fake_startup(struct usb_serial *serial)
release_firmware(fw); release_firmware(fw);
/* bring device out of reset. Renumeration will occur in a /* bring device out of reset. Renumeration will occur in a
moment and the new device will bind to the real driver */ moment and the new device will bind to the real driver */
response = ezusb_set_reset(serial, 0); response = ezusb_set_reset(serial->dev, 0);
/* we don't want this device to have a driver assigned to it. */ /* we don't want this device to have a driver assigned to it. */
return 1; return 1;

6
drivers/usb/serial/keyspan_pda.c
View file

@ -682,7 +682,7 @@ static int keyspan_pda_fake_startup(struct usb_serial *serial)
const struct firmware *fw; const struct firmware *fw;
/* download the firmware here ... */ /* download the firmware here ... */
response = ezusb_set_reset(serial, 1); response = ezusb_set_reset(serial->dev, 1);
if (0) { ; } if (0) { ; }
#ifdef KEYSPAN #ifdef KEYSPAN
@ -707,7 +707,7 @@ static int keyspan_pda_fake_startup(struct usb_serial *serial)
record = (const struct ihex_binrec *)fw->data; record = (const struct ihex_binrec *)fw->data;
while (record) { while (record) {
response = ezusb_writememory(serial, be32_to_cpu(record->addr), response = ezusb_writememory(serial->dev, be32_to_cpu(record->addr),
(unsigned char *)record->data, (unsigned char *)record->data,
be16_to_cpu(record->len), 0xa0); be16_to_cpu(record->len), 0xa0);
if (response < 0) { if (response < 0) {
@ -722,7 +722,7 @@ static int keyspan_pda_fake_startup(struct usb_serial *serial)
release_firmware(fw); release_firmware(fw);
/* bring device out of reset. Renumeration will occur in a moment /* bring device out of reset. Renumeration will occur in a moment
and the new device will bind to the real driver */ and the new device will bind to the real driver */
response = ezusb_set_reset(serial, 0); response = ezusb_set_reset(serial->dev, 0);
/* we want this device to fail to have a driver assigned to it. */ /* we want this device to fail to have a driver assigned to it. */
return 1; return 1;

26
drivers/usb/serial/whiteheat.c
View file

@ -213,13 +213,13 @@ static int whiteheat_firmware_download(struct usb_serial *serial,
goto out; goto out;
} }
ret = 0; ret = 0;
response = ezusb_set_reset (serial, 1); response = ezusb_set_reset(serial->dev, 1);
record = (const struct ihex_binrec *)loader_fw->data; record = (const struct ihex_binrec *)loader_fw->data;
while (record) { while (record) {
response = ezusb_writememory (serial, be32_to_cpu(record->addr), response = ezusb_writememory(serial->dev, be32_to_cpu(record->addr),
(unsigned char *)record->data, (unsigned char *)record->data,
be16_to_cpu(record->len), 0xa0); be16_to_cpu(record->len), 0xa0);
if (response < 0) { if (response < 0) {
dev_err(&serial->dev->dev, "%s - ezusb_writememory " dev_err(&serial->dev->dev, "%s - ezusb_writememory "
"failed for loader (%d %04X %p %d)\n", "failed for loader (%d %04X %p %d)\n",
@ -230,15 +230,15 @@ static int whiteheat_firmware_download(struct usb_serial *serial,
record = ihex_next_binrec(record); record = ihex_next_binrec(record);
} }
response = ezusb_set_reset(serial, 0); response = ezusb_set_reset(serial->dev, 0);
record = (const struct ihex_binrec *)firmware_fw->data; record = (const struct ihex_binrec *)firmware_fw->data;
while (record && be32_to_cpu(record->addr) < 0x1b40) while (record && be32_to_cpu(record->addr) < 0x1b40)
record = ihex_next_binrec(record); record = ihex_next_binrec(record);
while (record) { while (record) {
response = ezusb_writememory (serial, be32_to_cpu(record->addr), response = ezusb_writememory(serial->dev, be32_to_cpu(record->addr),
(unsigned char *)record->data, (unsigned char *)record->data,
be16_to_cpu(record->len), 0xa3); be16_to_cpu(record->len), 0xa3);
if (response < 0) { if (response < 0) {
dev_err(&serial->dev->dev, "%s - ezusb_writememory " dev_err(&serial->dev->dev, "%s - ezusb_writememory "
"failed for first firmware step " "failed for first firmware step "
@ -250,13 +250,13 @@ static int whiteheat_firmware_download(struct usb_serial *serial,
++record; ++record;
} }
response = ezusb_set_reset(serial, 1); response = ezusb_set_reset(serial->dev, 1);
record = (const struct ihex_binrec *)firmware_fw->data; record = (const struct ihex_binrec *)firmware_fw->data;
while (record && be32_to_cpu(record->addr) < 0x1b40) { while (record && be32_to_cpu(record->addr) < 0x1b40) {
response = ezusb_writememory (serial, be32_to_cpu(record->addr), response = ezusb_writememory(serial->dev, be32_to_cpu(record->addr),
(unsigned char *)record->data, (unsigned char *)record->data,
be16_to_cpu(record->len), 0xa0); be16_to_cpu(record->len), 0xa0);
if (response < 0) { if (response < 0) {
dev_err(&serial->dev->dev, "%s - ezusb_writememory " dev_err(&serial->dev->dev, "%s - ezusb_writememory "
"failed for second firmware step " "failed for second firmware step "
@ -268,7 +268,7 @@ static int whiteheat_firmware_download(struct usb_serial *serial,
++record; ++record;
} }
ret = 0; ret = 0;
response = ezusb_set_reset (serial, 0); response = ezusb_set_reset(serial->dev, 0);
out: out:
release_firmware(loader_fw); release_firmware(loader_fw);
release_firmware(firmware_fw); release_firmware(firmware_fw);

4
include/linux/usb/serial.h
View file

@ -301,9 +301,9 @@ extern void usb_serial_port_softint(struct usb_serial_port *port);
extern int usb_serial_suspend(struct usb_interface *intf, pm_message_t message); extern int usb_serial_suspend(struct usb_interface *intf, pm_message_t message);
extern int usb_serial_resume(struct usb_interface *intf); extern int usb_serial_resume(struct usb_interface *intf);
extern int ezusb_writememory(struct usb_serial *serial, int address, extern int ezusb_writememory(struct usb_device *dev, int address,
unsigned char *data, int length, __u8 bRequest); unsigned char *data, int length, __u8 bRequest);
extern int ezusb_set_reset(struct usb_serial *serial, unsigned char reset_bit); extern int ezusb_set_reset(struct usb_device *dev, unsigned char reset_bit);
/* USB Serial console functions */ /* USB Serial console functions */
#ifdef CONFIG_USB_SERIAL_CONSOLE #ifdef CONFIG_USB_SERIAL_CONSOLE