mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

ipmi: Remove the now unused priority from SMI sender 

Since the queue was moved into the message handler, the priority
field is now irrelevant.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Corey Minyard 2014-11-07 07:57:31 -06:00
parent b874b985c8
commit 99ab32f3b5
3 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/ipmi/ipmi_msghandler.c
View File

@ -1516,7 +1516,7 @@ static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags); spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
if (smi_msg) if (smi_msg)
handlers->sender(intf->send_info, smi_msg, 0); handlers->sender(intf->send_info, smi_msg);
} }
/* /*
@ -3908,7 +3908,7 @@ static void smi_recv_tasklet(unsigned long val)
if (!run_to_completion) if (!run_to_completion)
spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags); spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
if (newmsg) if (newmsg)
intf->handlers->sender(intf->send_info, newmsg, 0); intf->handlers->sender(intf->send_info, newmsg);
handle_new_recv_msgs(intf); handle_new_recv_msgs(intf);
} }

3
drivers/char/ipmi/ipmi_si_intf.c
View File

@ -892,8 +892,7 @@ static void check_start_timer_thread(struct smi_info *smi_info)
} }
static void sender(void *send_info, static void sender(void *send_info,
struct ipmi_smi_msg *msg, struct ipmi_smi_msg *msg)
int priority)
{ {
struct smi_info *smi_info = send_info; struct smi_info *smi_info = send_info;
enum si_sm_result result; enum si_sm_result result;

9
include/linux/ipmi_smi.h
View File

@ -98,12 +98,11 @@ struct ipmi_smi_handlers {
operation is not allowed to fail. If an error occurs, it operation is not allowed to fail. If an error occurs, it
should report back the error in a received message. It may should report back the error in a received message. It may
do this in the current call context, since no write locks do this in the current call context, since no write locks
are held when this is run. If the priority is > 0, the are held when this is run. Message are delivered one at
message will go into a high-priority queue and be sent a time by the message handler, a new message will not be
first. Otherwise, it goes into a normal-priority queue. */ delivered until the previous message is returned. */
void (*sender)(void *send_info, void (*sender)(void *send_info,
struct ipmi_smi_msg *msg, struct ipmi_smi_msg *msg);
int priority);
/* Called by the upper layer to request that we try to get /* Called by the upper layer to request that we try to get
events from the BMC we are attached to. */ events from the BMC we are attached to. */