mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
platform/chrome: cros_ec_typec: zero out stale pointers
`cros_typec_get_switch_handles` allocates four pointers when obtaining type-c switch handles. These pointers are all freed if failing to obtain any of them; therefore, pointers in `port` become stale. The stale pointers eventually cause use-after-free or double free in later code paths. Zeroing out all pointer fields after freeing to eliminate these stale pointers. Fixes:f28adb41da
("platform/chrome: cros_ec_typec: Register Type C switches") Fixes:1a8912caba
("platform/chrome: cros_ec_typec: Get retimer handle") Signed-off-by: Victor Ding <victording@chromium.org> Acked-by: Prashant Malani <pmalani@chromium.org> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Link: https://lore.kernel.org/r/20221207093924.v2.1.I1864b6a7ee98824118b93677868d22d3750f439b@changeid
This commit is contained in:
parent
5a2d966236
commit
9a8aadcf0b
1 changed files with 3 additions and 0 deletions
|
@ -173,10 +173,13 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port,
|
|||
|
||||
role_sw_err:
|
||||
typec_switch_put(port->ori_sw);
|
||||
port->ori_sw = NULL;
|
||||
ori_sw_err:
|
||||
typec_retimer_put(port->retimer);
|
||||
port->retimer = NULL;
|
||||
retimer_sw_err:
|
||||
typec_mux_put(port->mux);
|
||||
port->mux = NULL;
|
||||
mux_err:
|
||||
return -ENODEV;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue