mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 07:38:10 +00:00
ext4: fix potential memory leak in ext4_fc_record_modified_inode()
commit 9305721a30
upstream.
As krealloc may return NULL, in this case 'state->fc_modified_inodes'
may not be freed by krealloc, but 'state->fc_modified_inodes' already
set NULL. Then will lead to 'state->fc_modified_inodes' memory leak.
Cc: stable@kernel.org
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220921064040.3693255-2-yebin10@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ef1607c991
commit
9b5eb368a8
1 changed files with 5 additions and 3 deletions
|
@ -1414,13 +1414,15 @@ static int ext4_fc_record_modified_inode(struct super_block *sb, int ino)
|
|||
if (state->fc_modified_inodes[i] == ino)
|
||||
return 0;
|
||||
if (state->fc_modified_inodes_used == state->fc_modified_inodes_size) {
|
||||
state->fc_modified_inodes = krealloc(
|
||||
state->fc_modified_inodes,
|
||||
int *fc_modified_inodes;
|
||||
|
||||
fc_modified_inodes = krealloc(state->fc_modified_inodes,
|
||||
sizeof(int) * (state->fc_modified_inodes_size +
|
||||
EXT4_FC_REPLAY_REALLOC_INCREMENT),
|
||||
GFP_KERNEL);
|
||||
if (!state->fc_modified_inodes)
|
||||
if (!fc_modified_inodes)
|
||||
return -ENOMEM;
|
||||
state->fc_modified_inodes = fc_modified_inodes;
|
||||
state->fc_modified_inodes_size +=
|
||||
EXT4_FC_REPLAY_REALLOC_INCREMENT;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue