mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 23:25:07 +00:00
genetlink: Fix a memory leak on error path
[ Upstream commitceabee6c59
] In genl_register_family(), when idr_alloc() fails, we forget to free the memory we possibly allocate for family->attrbuf. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes:2ae0f17df1
("genetlink: use idr to track families") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
321461f249
commit
9b8ef421b4
1 changed files with 2 additions and 1 deletions
|
@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
|
|||
start, end + 1, GFP_KERNEL);
|
||||
if (family->id < 0) {
|
||||
err = family->id;
|
||||
goto errout_locked;
|
||||
goto errout_free;
|
||||
}
|
||||
|
||||
err = genl_validate_assign_mc_groups(family);
|
||||
|
@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)
|
|||
|
||||
errout_remove:
|
||||
idr_remove(&genl_fam_idr, family->id);
|
||||
errout_free:
|
||||
kfree(family->attrbuf);
|
||||
errout_locked:
|
||||
genl_unlock_all();
|
||||
|
|
Loading…
Reference in a new issue