mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
greth: greth_set_mac_add would corrupt the MAC address.
The MAC address was set using the signed char sockaddr->sa_addr field and thus the address could be corrupted through sign extension. Signed-off-by: Kristoffer Glembo <kristoffer@gaisler.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
c349a528cd
commit
9b9cfe7cf6
1 changed files with 3 additions and 4 deletions
|
@ -1015,11 +1015,10 @@ static int greth_set_mac_add(struct net_device *dev, void *p)
|
|||
return -EINVAL;
|
||||
|
||||
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
|
||||
GRETH_REGSAVE(regs->esa_msb, dev->dev_addr[0] << 8 | dev->dev_addr[1]);
|
||||
GRETH_REGSAVE(regs->esa_lsb, dev->dev_addr[2] << 24 | dev->dev_addr[3] << 16 |
|
||||
dev->dev_addr[4] << 8 | dev->dev_addr[5]);
|
||||
|
||||
GRETH_REGSAVE(regs->esa_msb, addr->sa_data[0] << 8 | addr->sa_data[1]);
|
||||
GRETH_REGSAVE(regs->esa_lsb,
|
||||
addr->sa_data[2] << 24 | addr->
|
||||
sa_data[3] << 16 | addr->sa_data[4] << 8 | addr->sa_data[5]);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue