mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 17:59:32 +00:00
drivers: video: fbcmap: remove the redundency and incorrect checkings
fb_set_cmap() already checks the parameters, so need remove the redundancy checking. This redundancy checking is also incorrect, the related warning: drivers/video/fbcmap.c:288:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
parent
51617d1bc8
commit
9bb40585c9
1 changed files with 1 additions and 6 deletions
|
@ -285,13 +285,8 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info)
|
||||||
rc = -ENODEV;
|
rc = -ENODEV;
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
if (cmap->start < 0 || (!info->fbops->fb_setcolreg &&
|
|
||||||
!info->fbops->fb_setcmap)) {
|
|
||||||
rc = -EINVAL;
|
|
||||||
goto out1;
|
|
||||||
}
|
|
||||||
rc = fb_set_cmap(&umap, info);
|
rc = fb_set_cmap(&umap, info);
|
||||||
out1:
|
|
||||||
unlock_fb_info(info);
|
unlock_fb_info(info);
|
||||||
out:
|
out:
|
||||||
fb_dealloc_cmap(&umap);
|
fb_dealloc_cmap(&umap);
|
||||||
|
|
Loading…
Reference in a new issue