media: v4l2-mem2mem: fix a memleak in v4l2_m2m_register_entity
[ Upstream commit8f94b49a5b
] The entity->name (i.e. name) is allocated in v4l2_m2m_register_entity but isn't freed in its following error-handling paths. This patch adds such deallocation to prevent memleak of entity->name. Fixes:be2fff6563
("media: add helpers for memory-to-memory media controller") Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
622b1cf385
commit
9c23ef30e8
|
@ -1087,11 +1087,17 @@ static int v4l2_m2m_register_entity(struct media_device *mdev,
|
||||||
entity->function = function;
|
entity->function = function;
|
||||||
|
|
||||||
ret = media_entity_pads_init(entity, num_pads, pads);
|
ret = media_entity_pads_init(entity, num_pads, pads);
|
||||||
if (ret)
|
if (ret) {
|
||||||
|
kfree(entity->name);
|
||||||
|
entity->name = NULL;
|
||||||
return ret;
|
return ret;
|
||||||
|
}
|
||||||
ret = media_device_register_entity(mdev, entity);
|
ret = media_device_register_entity(mdev, entity);
|
||||||
if (ret)
|
if (ret) {
|
||||||
|
kfree(entity->name);
|
||||||
|
entity->name = NULL;
|
||||||
return ret;
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue