efivarfs: Drop redundant cleanup on fill_super() failure

Al points out that kill_sb() will be called if efivarfs_fill_super()
fails and so there is no point in cleaning up the efivar entry list.

Reported-by: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This commit is contained in:
Ard Biesheuvel 2024-02-24 18:45:41 +01:00
parent f45812cc23
commit 9ca01c7adf
1 changed files with 1 additions and 6 deletions

View File

@ -343,12 +343,7 @@ static int efivarfs_fill_super(struct super_block *sb, struct fs_context *fc)
if (err)
return err;
err = efivar_init(efivarfs_callback, (void *)sb, true,
&sfi->efivarfs_list);
if (err)
efivar_entry_iter(efivarfs_destroy, &sfi->efivarfs_list, NULL);
return err;
return efivar_init(efivarfs_callback, sb, true, &sfi->efivarfs_list);
}
static int efivarfs_get_tree(struct fs_context *fc)