mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 22:25:03 +00:00
nfp: flower: restore RTNL locking around representor updates
When we moved to updating representors from a workqueue grabbing
the RTNL somehow got lost in the process. Restore it, and make
sure RCU lock is not held while we are grabbing the RTNL. RCU
protects the representor table, so since we will be under RTNL
we can drop RCU lock as soon as we find the netdev pointer.
RTNL is needed for the dev_set_mtu() call.
Fixes: 2dff196224
("nfp: process MTU updates from firmware flower app")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
7c8a2d8b36
commit
9ce4fa5483
1 changed files with 4 additions and 2 deletions
|
@ -141,12 +141,14 @@ nfp_flower_cmsg_portmod_rx(struct nfp_app *app, struct sk_buff *skb)
|
|||
msg = nfp_flower_cmsg_get_data(skb);
|
||||
link = msg->info & NFP_FLOWER_CMSG_PORTMOD_INFO_LINK;
|
||||
|
||||
rtnl_lock();
|
||||
rcu_read_lock();
|
||||
netdev = nfp_app_repr_get(app, be32_to_cpu(msg->portnum));
|
||||
rcu_read_unlock();
|
||||
if (!netdev) {
|
||||
nfp_flower_cmsg_warn(app, "ctrl msg for unknown port 0x%08x\n",
|
||||
be32_to_cpu(msg->portnum));
|
||||
rcu_read_unlock();
|
||||
rtnl_unlock();
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -161,7 +163,7 @@ nfp_flower_cmsg_portmod_rx(struct nfp_app *app, struct sk_buff *skb)
|
|||
} else {
|
||||
netif_carrier_off(netdev);
|
||||
}
|
||||
rcu_read_unlock();
|
||||
rtnl_unlock();
|
||||
}
|
||||
|
||||
static void
|
||||
|
|
Loading…
Reference in a new issue