mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-25 11:55:37 +00:00
mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()
[ Upstream commit188043c7f4
] damon_reclaim_init() allocates a memory chunk for ctx with damon_new_ctx(). When damon_select_ops() fails, ctx is not released, which will lead to a memory leak. We should release the ctx with damon_destroy_ctx() when damon_select_ops() fails to fix the memory leak. Link: https://lkml.kernel.org/r/20220714063746.2343549-1-niejianglei2021@163.com Fixes:4d69c34578
("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()") Signed-off-by: Jianglei Nie <niejianglei2021@163.com> Reviewed-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
74af83732a
commit
9d3e9e1e08
1 changed files with 3 additions and 1 deletions
|
@ -384,8 +384,10 @@ static int __init damon_reclaim_init(void)
|
||||||
if (!ctx)
|
if (!ctx)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
if (damon_select_ops(ctx, DAMON_OPS_PADDR))
|
if (damon_select_ops(ctx, DAMON_OPS_PADDR)) {
|
||||||
|
damon_destroy_ctx(ctx);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
ctx->callback.after_aggregation = damon_reclaim_after_aggregation;
|
ctx->callback.after_aggregation = damon_reclaim_after_aggregation;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue