mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 09:59:32 +00:00
btrfs: change the lockdep class of free space inode's invalidate_lock
Reinitialize the class of the lockdep map for struct inode's mapping->invalidate_lock in load_free_space_cache() function in fs/btrfs/free-space-cache.c. This will prevent lockdep from producing false positives related to execution paths that make use of free space inodes and paths that make use of normal inodes. Specifically, with this change lockdep will create separate lock dependencies that include the invalidate_lock, in the case that free space inodes are used and in the case that normal inodes are used. The lockdep class for this lock was first initialized in inode_init_always() in fs/inode.c. Reviewed-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Ioannis Angelakopoulos <iangelak@fb.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
8b53779eaa
commit
9d7464c87b
1 changed files with 10 additions and 0 deletions
|
@ -920,6 +920,8 @@ static int copy_free_space_cache(struct btrfs_block_group *block_group,
|
|||
return ret;
|
||||
}
|
||||
|
||||
static struct lock_class_key btrfs_free_space_inode_key;
|
||||
|
||||
int load_free_space_cache(struct btrfs_block_group *block_group)
|
||||
{
|
||||
struct btrfs_fs_info *fs_info = block_group->fs_info;
|
||||
|
@ -989,6 +991,14 @@ int load_free_space_cache(struct btrfs_block_group *block_group)
|
|||
}
|
||||
spin_unlock(&block_group->lock);
|
||||
|
||||
/*
|
||||
* Reinitialize the class of struct inode's mapping->invalidate_lock for
|
||||
* free space inodes to prevent false positives related to locks for normal
|
||||
* inodes.
|
||||
*/
|
||||
lockdep_set_class(&(&inode->i_data)->invalidate_lock,
|
||||
&btrfs_free_space_inode_key);
|
||||
|
||||
ret = __load_free_space_cache(fs_info->tree_root, inode, &tmp_ctl,
|
||||
path, block_group->start);
|
||||
btrfs_free_path(path);
|
||||
|
|
Loading…
Reference in a new issue