mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 03:40:04 +00:00
openvswitch: fix send of uninitialized stack memory in ct limit reply
[ Upstream commit4d51419d49
] 'struct ovs_zone_limit' has more members than initialized in ovs_ct_limit_get_default_limit(). The rest of the memory is a random kernel stack content that ends up being sent to userspace. Fix that by using designated initializer that will clear all non-specified fields. Fixes:11efd5cb04
("openvswitch: Support conntrack zone limit") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
731abf396e
commit
9dd7092d1a
1 changed files with 4 additions and 4 deletions
|
@ -2019,10 +2019,10 @@ static int ovs_ct_limit_del_zone_limit(struct nlattr *nla_zone_limit,
|
|||
static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info,
|
||||
struct sk_buff *reply)
|
||||
{
|
||||
struct ovs_zone_limit zone_limit;
|
||||
|
||||
zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE;
|
||||
zone_limit.limit = info->default_limit;
|
||||
struct ovs_zone_limit zone_limit = {
|
||||
.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE,
|
||||
.limit = info->default_limit,
|
||||
};
|
||||
|
||||
return nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue