selftests: refactor get_netdev_name function

As pointed out by Michal Kubecek, getting the name
with the previous approach was racy, it's better
and easier to get the name of the device with this
patch's approach.

Essentialy the function doesn't need to exist
anymore as it's a simple 'ls' command.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Antonio Cardace 2020-11-18 21:45:21 +01:00 committed by Jakub Kicinski
parent fbb8531e58
commit 9e48ee80ac

View file

@ -20,23 +20,6 @@ function cleanup {
trap cleanup EXIT
function get_netdev_name {
local -n old=$1
new=$(ls /sys/class/net)
for netdev in $new; do
for check in $old; do
[ $netdev == $check ] && break
done
if [ $netdev != $check ]; then
echo $netdev
break
fi
done
}
function check {
local code=$1
local str=$2
@ -65,5 +48,6 @@ function make_netdev {
fi
echo $NSIM_ID > /sys/bus/netdevsim/new_device
echo `get_netdev_name old_netdevs`
# get new device name
ls /sys/bus/netdevsim/devices/netdevsim${NSIM_ID}/net/
}