mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

hwmon: (ibmpowernv) add a helper routine create_hwmon_attr 

This should shorten a bit the code necessary to create a hmwon attribute.

Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Cédric Le Goater 2015-04-08 19:19:47 +02:00 committed by Guenter Roeck
parent fa3f70d628
commit 9e4f74b119
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/hwmon/ibmpowernv.c
View File

@ -232,6 +232,21 @@ static int populate_attr_groups(struct platform_device *pdev)
return 0;
}
static void create_hwmon_attr(struct sensor_data *sdata, const char *attr_name,
ssize_t (*show)(struct device *dev,
struct device_attribute *attr,
char *buf))
{
snprintf(sdata->name, MAX_ATTR_LEN, "%s%d_%s",
sensor_groups[sdata->type].name, sdata->hwmon_index,
attr_name);
sysfs_attr_init(&sdata->dev_attr.attr);
sdata->dev_attr.attr.name = sdata->name;
sdata->dev_attr.attr.mode = S_IRUGO;
sdata->dev_attr.show = show;
}
/*
* Iterate through the device tree for each child of 'sensors' node, create
* a sysfs attribute file, the file is named by translating the DT node name
@ -290,14 +305,7 @@ static int create_device_attrs(struct platform_device *pdev)
sdata[count].hwmon_index =
get_sensor_hwmon_index(&sdata[count], sdata, count);
snprintf(sdata[count].name, MAX_ATTR_LEN, "%s%d_%s",
sensor_groups[type].name, sdata[count].hwmon_index,
attr_name);
sysfs_attr_init(&sdata[count].dev_attr.attr);
sdata[count].dev_attr.attr.name = sdata[count].name;
sdata[count].dev_attr.attr.mode = S_IRUGO;
sdata[count].dev_attr.show = show_sensor;
create_hwmon_attr(&sdata[count], attr_name, show_sensor);
pgroups[type]->attrs[sensor_groups[type].attr_count++] =
&sdata[count++].dev_attr.attr;