mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-27 22:51:31 +00:00
Code Issues Releases Wiki Activity

ipvs: only unlock in ip_vs_edit_service() if already locked

Browse source 
Jumping to out unlocks __ip_vs_svc_lock, but that lock is not taken until
after code that may jump to out.

This problem was detected by sparse.

make C=1
  CHECK   net/ipv4/ipvs/ip_vs_ctl.c
net/ipv4/ipvs/ip_vs_ctl.c:1332:2: warning: context imbalance in 'ip_vs_edit_service' - unexpected unlock

Acked-by: Sven Wegener <sven.wegener@stealer.net>
Acked-by: Julius Volz <juliusv@google.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
This commit is contained in:
Simon Horman 2008-09-17 10:10:41 +10:00
parent e8ae43ec6d
commit 9e691ed68d
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
net/ipv4/ipvs/ip_vs_ctl.c
View file

@ -1305,7 +1305,7 @@ ip_vs_edit_service(struct ip_vs_service *svc, struct ip_vs_service_user_kern *u)
*/ */
if ((ret = ip_vs_unbind_scheduler(svc))) { if ((ret = ip_vs_unbind_scheduler(svc))) {
old_sched = sched; old_sched = sched;
goto out; goto out_unlock;
} }
/* /*
@ -1324,12 +1324,13 @@ ip_vs_edit_service(struct ip_vs_service *svc, struct ip_vs_service_user_kern *u)
*/ */
ip_vs_bind_scheduler(svc, old_sched); ip_vs_bind_scheduler(svc, old_sched);
old_sched = sched; old_sched = sched;
goto out; goto out_unlock;
} }
} }
out: out_unlock:
write_unlock_bh(&__ip_vs_svc_lock); write_unlock_bh(&__ip_vs_svc_lock);
out:
if (old_sched) if (old_sched)
ip_vs_scheduler_put(old_sched); ip_vs_scheduler_put(old_sched);