mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
[SCSI] fcoe: reset FIP ctlr link state on disable/enable
The FIP controler state wasn't being reset on a disable. A disable/enable sequence should be treated as a link event. Otherwise, when using disable to mask a time when the link is up but unusable, FCF discovery would attempt to continue and login would jump directly to the non-FIP fallback on enable. Signed-off-by: Chris Leech <christopher.leech@intel.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
parent
593abc0720
commit
9ee50e48d8
1 changed files with 7 additions and 4 deletions
|
@ -1901,9 +1901,10 @@ static int fcoe_disable(const char *buffer, struct kernel_param *kp)
|
||||||
fcoe = fcoe_hostlist_lookup_port(netdev);
|
fcoe = fcoe_hostlist_lookup_port(netdev);
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
|
|
||||||
if (fcoe)
|
if (fcoe) {
|
||||||
fc_fabric_logoff(fcoe->ctlr.lp);
|
fc_fabric_logoff(fcoe->ctlr.lp);
|
||||||
else
|
fcoe_ctlr_link_down(&fcoe->ctlr);
|
||||||
|
} else
|
||||||
rc = -ENODEV;
|
rc = -ENODEV;
|
||||||
|
|
||||||
dev_put(netdev);
|
dev_put(netdev);
|
||||||
|
@ -1950,9 +1951,11 @@ static int fcoe_enable(const char *buffer, struct kernel_param *kp)
|
||||||
fcoe = fcoe_hostlist_lookup_port(netdev);
|
fcoe = fcoe_hostlist_lookup_port(netdev);
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
|
|
||||||
if (fcoe)
|
if (fcoe) {
|
||||||
|
if (!fcoe_link_ok(fcoe->ctlr.lp))
|
||||||
|
fcoe_ctlr_link_up(&fcoe->ctlr);
|
||||||
rc = fc_fabric_login(fcoe->ctlr.lp);
|
rc = fc_fabric_login(fcoe->ctlr.lp);
|
||||||
else
|
} else
|
||||||
rc = -ENODEV;
|
rc = -ENODEV;
|
||||||
|
|
||||||
dev_put(netdev);
|
dev_put(netdev);
|
||||||
|
|
Loading…
Reference in a new issue