mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
interconnect: qcom: qcs404: Walk the list safely on node removal
commitf39488ea2a
upstream. As we will remove items off the list using list_del(), we need to use the safe version of list_for_each_entry(). Fixes:5e4e6c4d3a
("interconnect: qcom: Add QCS404 interconnect provider driver") Reported-by: Dmitry Osipenko <digetx@gmail.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org> Cc: <stable@vger.kernel.org> # v5.4 Link: https://lore.kernel.org/r/20191212075332.16202-4-georgi.djakov@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
48b47dfd04
commit
9fb0a8c74c
1 changed files with 4 additions and 4 deletions
|
@ -414,7 +414,7 @@ static int qnoc_probe(struct platform_device *pdev)
|
|||
struct icc_provider *provider;
|
||||
struct qcom_icc_node **qnodes;
|
||||
struct qcom_icc_provider *qp;
|
||||
struct icc_node *node;
|
||||
struct icc_node *node, *tmp;
|
||||
size_t num_nodes, i;
|
||||
int ret;
|
||||
|
||||
|
@ -494,7 +494,7 @@ static int qnoc_probe(struct platform_device *pdev)
|
|||
|
||||
return 0;
|
||||
err:
|
||||
list_for_each_entry(node, &provider->nodes, node_list) {
|
||||
list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
|
||||
icc_node_del(node);
|
||||
icc_node_destroy(node->id);
|
||||
}
|
||||
|
@ -508,9 +508,9 @@ static int qnoc_remove(struct platform_device *pdev)
|
|||
{
|
||||
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
|
||||
struct icc_provider *provider = &qp->provider;
|
||||
struct icc_node *n;
|
||||
struct icc_node *n, *tmp;
|
||||
|
||||
list_for_each_entry(n, &provider->nodes, node_list) {
|
||||
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
|
||||
icc_node_del(n);
|
||||
icc_node_destroy(n->id);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue