From a04e96537cc64b63fbeb300df2503167bb54f2a1 Mon Sep 17 00:00:00 2001 From: Joachim Wiberg Date: Sat, 9 Oct 2021 08:09:54 +0200 Subject: [PATCH] mtd: block2mtd: minor refactor to avoid hard coded constant Signed-off-by: Joachim Wiberg Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20211009060955.552636-2-troglobit@gmail.com --- drivers/mtd/devices/block2mtd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c index c08721b11642..6c2871788d59 100644 --- a/drivers/mtd/devices/block2mtd.c +++ b/drivers/mtd/devices/block2mtd.c @@ -31,6 +31,9 @@ #include #include +/* Maximum number of comma-separated items in the 'block2mtd=' parameter */ +#define BLOCK2MTD_PARAM_MAX_COUNT 2 + /* Info for the block device */ struct block2mtd_dev { struct list_head list; @@ -381,7 +384,7 @@ static int block2mtd_setup2(const char *val) /* 80 for device, 12 for erase size, 80 for name, 8 for timeout */ char buf[80 + 12 + 80 + 8]; char *str = buf; - char *token[2]; + char *token[BLOCK2MTD_PARAM_MAX_COUNT]; char *name; size_t erase_size = PAGE_SIZE; unsigned long timeout = MTD_DEFAULT_TIMEOUT; @@ -395,7 +398,7 @@ static int block2mtd_setup2(const char *val) strcpy(str, val); kill_final_newline(str); - for (i = 0; i < 2; i++) + for (i = 0; i < BLOCK2MTD_PARAM_MAX_COUNT; i++) token[i] = strsep(&str, ","); if (str) {