mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 00:39:48 +00:00
ASoC: fsl: imx-pcm-rpmsg: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Takashi Iwai <tiwai@suse.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Link: https://lore.kernel.org/r/20230315150745.67084-78-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
51451f46d1
commit
a064945698
1 changed files with 2 additions and 4 deletions
|
@ -743,14 +743,12 @@ static int imx_rpmsg_pcm_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int imx_rpmsg_pcm_remove(struct platform_device *pdev)
|
||||
static void imx_rpmsg_pcm_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct rpmsg_info *info = platform_get_drvdata(pdev);
|
||||
|
||||
if (info->rpmsg_wq)
|
||||
destroy_workqueue(info->rpmsg_wq);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM
|
||||
|
@ -821,7 +819,7 @@ static const struct dev_pm_ops imx_rpmsg_pcm_pm_ops = {
|
|||
|
||||
static struct platform_driver imx_pcm_rpmsg_driver = {
|
||||
.probe = imx_rpmsg_pcm_probe,
|
||||
.remove = imx_rpmsg_pcm_remove,
|
||||
.remove_new = imx_rpmsg_pcm_remove,
|
||||
.driver = {
|
||||
.name = IMX_PCM_DRV_NAME,
|
||||
.pm = &imx_rpmsg_pcm_pm_ops,
|
||||
|
|
Loading…
Reference in a new issue