mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
ext4: mballoc: Remove useless setting of ac_criteria
[ Upstream commit569f196f1e
] There will be changes coming in future patches which will introduce a new criteria for block allocation. This removes the useless setting of ac_criteria. AFAIU, this might be only used to differentiate between whether a preallocated blocks was allocated or was regular allocator called for allocating blocks. Hence this also adds the debug prints to identify what type of block allocation was done in ext4_mb_show_ac(). Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/1dbae05617519cb6202f1b299c9d1be3e7cda763.1685449706.git.ojaswin@linux.ibm.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Stable-dep-of:9d3de7ee19
("ext4: fix rbtree traversal bug in ext4_mb_use_preallocated") Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
d254d88140
commit
a0f2ba1866
1 changed files with 4 additions and 2 deletions
|
@ -4614,7 +4614,6 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
|
|||
atomic_inc(&tmp_pa->pa_count);
|
||||
ext4_mb_use_inode_pa(ac, tmp_pa);
|
||||
spin_unlock(&tmp_pa->pa_lock);
|
||||
ac->ac_criteria = 10;
|
||||
read_unlock(&ei->i_prealloc_lock);
|
||||
return true;
|
||||
}
|
||||
|
@ -4657,7 +4656,6 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
|
|||
}
|
||||
if (cpa) {
|
||||
ext4_mb_use_group_pa(ac, cpa);
|
||||
ac->ac_criteria = 20;
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
|
@ -5431,6 +5429,10 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac)
|
|||
(unsigned long)ac->ac_b_ex.fe_logical,
|
||||
(int)ac->ac_criteria);
|
||||
mb_debug(sb, "%u found", ac->ac_found);
|
||||
mb_debug(sb, "used pa: %s, ", ac->ac_pa ? "yes" : "no");
|
||||
if (ac->ac_pa)
|
||||
mb_debug(sb, "pa_type %s\n", ac->ac_pa->pa_type == MB_GROUP_PA ?
|
||||
"group pa" : "inode pa");
|
||||
ext4_mb_show_pa(sb);
|
||||
}
|
||||
#else
|
||||
|
|
Loading…
Reference in a new issue