mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
pinctrl: samsung: Fix device node refcount leaks in init code
Several functions use for_each_child_of_node() loop with a break to find
a matching child node. Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it. This leads to leak of device node.
Cc: <stable@vger.kernel.org>
Fixes: 9a2c1c3b91
("pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
This commit is contained in:
parent
7f028caadf
commit
a322b3377f
1 changed files with 8 additions and 2 deletions
|
@ -272,6 +272,7 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *pctldev,
|
||||||
&reserved_maps, num_maps);
|
&reserved_maps, num_maps);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
samsung_dt_free_map(pctldev, *map, *num_maps);
|
samsung_dt_free_map(pctldev, *map, *num_maps);
|
||||||
|
of_node_put(np);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -785,8 +786,10 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions(
|
||||||
if (!of_get_child_count(cfg_np)) {
|
if (!of_get_child_count(cfg_np)) {
|
||||||
ret = samsung_pinctrl_create_function(dev, drvdata,
|
ret = samsung_pinctrl_create_function(dev, drvdata,
|
||||||
cfg_np, func);
|
cfg_np, func);
|
||||||
if (ret < 0)
|
if (ret < 0) {
|
||||||
|
of_node_put(cfg_np);
|
||||||
return ERR_PTR(ret);
|
return ERR_PTR(ret);
|
||||||
|
}
|
||||||
if (ret > 0) {
|
if (ret > 0) {
|
||||||
++func;
|
++func;
|
||||||
++func_cnt;
|
++func_cnt;
|
||||||
|
@ -797,8 +800,11 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions(
|
||||||
for_each_child_of_node(cfg_np, func_np) {
|
for_each_child_of_node(cfg_np, func_np) {
|
||||||
ret = samsung_pinctrl_create_function(dev, drvdata,
|
ret = samsung_pinctrl_create_function(dev, drvdata,
|
||||||
func_np, func);
|
func_np, func);
|
||||||
if (ret < 0)
|
if (ret < 0) {
|
||||||
|
of_node_put(func_np);
|
||||||
|
of_node_put(cfg_np);
|
||||||
return ERR_PTR(ret);
|
return ERR_PTR(ret);
|
||||||
|
}
|
||||||
if (ret > 0) {
|
if (ret > 0) {
|
||||||
++func;
|
++func;
|
||||||
++func_cnt;
|
++func_cnt;
|
||||||
|
|
Loading…
Reference in a new issue