mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
mm/memory_hotplug: use pfn math in place of direct struct page manipulation
commit1640a0ef80
upstream. When dealing with hugetlb pages, manipulating struct page pointers directly can get to wrong struct page, since struct page is not guaranteed to be contiguous on SPARSEMEM without VMEMMAP. Use pfn calculation to handle it properly. Without the fix, a wrong number of page might be skipped. Since skip cannot be negative, scan_movable_page() will end early and might miss a movable page with -ENOENT. This might fail offline_pages(). No bug is reported. The fix comes from code inspection. Link: https://lkml.kernel.org/r/20230913201248.452081-4-zi.yan@sent.com Fixes:eeb0efd071
("mm,memory_hotplug: fix scan_movable_pages() for gigantic hugepages") Signed-off-by: Zi Yan <ziy@nvidia.com> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Acked-by: David Hildenbrand <david@redhat.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: Mike Rapoport (IBM) <rppt@kernel.org> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
792a796085
commit
a466808812
1 changed files with 1 additions and 1 deletions
|
@ -1677,7 +1677,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
|
|||
*/
|
||||
if (HPageMigratable(head))
|
||||
goto found;
|
||||
skip = compound_nr(head) - (page - head);
|
||||
skip = compound_nr(head) - (pfn - page_to_pfn(head));
|
||||
pfn += skip - 1;
|
||||
}
|
||||
return -ENOENT;
|
||||
|
|
Loading…
Reference in a new issue