ASoC: Fail card instantiation if DAI format setup fails

[ Upstream commit 40aa5383e3 ]

If the DAI format setup fails, there is no valid communication format
between CPU and CODEC, so fail card instantiation, rather than continue
with a card that will most likely not function properly.

Signed-off-by: Ricard Wanderlof <ricardw@axis.com>
Link: https://lore.kernel.org/r/alpine.DEB.2.20.1907241132350.6338@lnxricardw1.se.axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ricard Wanderlof 2019-07-24 11:38:44 +02:00 committed by Greg Kroah-Hartman
parent 16c832681f
commit a56c79efe4

View file

@ -1757,8 +1757,11 @@ static int soc_probe_link_dais(struct snd_soc_card *card,
}
}
if (dai_link->dai_fmt)
snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt);
if (dai_link->dai_fmt) {
ret = snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt);
if (ret)
return ret;
}
ret = soc_post_component_init(rtd, dai_link->name);
if (ret)