mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-27 22:51:31 +00:00
video: fbdev: ssd1307fb: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
parent
626e021dab
commit
a644da2ec5
1 changed files with 3 additions and 4 deletions
|
@ -658,9 +658,8 @@ static int ssd1307fb_probe(struct i2c_client *client)
|
||||||
|
|
||||||
par->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
|
par->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
|
||||||
if (IS_ERR(par->reset)) {
|
if (IS_ERR(par->reset)) {
|
||||||
dev_err(dev, "failed to get reset gpio: %ld\n",
|
ret = dev_err_probe(dev, PTR_ERR(par->reset),
|
||||||
PTR_ERR(par->reset));
|
"failed to get reset gpio\n");
|
||||||
ret = PTR_ERR(par->reset);
|
|
||||||
goto fb_alloc_error;
|
goto fb_alloc_error;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -670,7 +669,7 @@ static int ssd1307fb_probe(struct i2c_client *client)
|
||||||
if (ret == -ENODEV) {
|
if (ret == -ENODEV) {
|
||||||
par->vbat_reg = NULL;
|
par->vbat_reg = NULL;
|
||||||
} else {
|
} else {
|
||||||
dev_err(dev, "failed to get VBAT regulator: %d\n", ret);
|
dev_err_probe(dev, ret, "failed to get VBAT regulator\n");
|
||||||
goto fb_alloc_error;
|
goto fb_alloc_error;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue