mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
devlink: Make sure devlink instance and port are in same net namespace
When devlink reload operation is not used, netdev of an Ethernet port may
be present in different net namespace than the net namespace of the
devlink instance.
Ensure that both the devlink instance and devlink port netdev are located
in same net namespace.
Fixes: 070c63f20f
("net: devlink: allow to change namespaces during reload")
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
b187c9b417
commit
a7b4364950
1 changed files with 2 additions and 1 deletions
|
@ -782,9 +782,10 @@ static int devlink_nl_port_fill(struct sk_buff *msg, struct devlink *devlink,
|
||||||
devlink_port->desired_type))
|
devlink_port->desired_type))
|
||||||
goto nla_put_failure_type_locked;
|
goto nla_put_failure_type_locked;
|
||||||
if (devlink_port->type == DEVLINK_PORT_TYPE_ETH) {
|
if (devlink_port->type == DEVLINK_PORT_TYPE_ETH) {
|
||||||
|
struct net *net = devlink_net(devlink_port->devlink);
|
||||||
struct net_device *netdev = devlink_port->type_dev;
|
struct net_device *netdev = devlink_port->type_dev;
|
||||||
|
|
||||||
if (netdev &&
|
if (netdev && net_eq(net, dev_net(netdev)) &&
|
||||||
(nla_put_u32(msg, DEVLINK_ATTR_PORT_NETDEV_IFINDEX,
|
(nla_put_u32(msg, DEVLINK_ATTR_PORT_NETDEV_IFINDEX,
|
||||||
netdev->ifindex) ||
|
netdev->ifindex) ||
|
||||||
nla_put_string(msg, DEVLINK_ATTR_PORT_NETDEV_NAME,
|
nla_put_string(msg, DEVLINK_ATTR_PORT_NETDEV_NAME,
|
||||||
|
|
Loading…
Reference in a new issue