mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
usb: max-3421: Fix setting of I/O pins
To update the I/O pins, the registers are read/modified/written. The
read operation incorrectly always read the first register. Although
wrong, there wasn't any impact as all the output pins are always
written, and the inputs are read only anyway.
Fixes: 2d53139f31
("Add support for using a MAX3421E chip as a host driver.")
Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20230207033337.18112-1-mark.tomlinson@alliedtelesis.co.nz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
41070a7027
commit
a7efe3fc7c
1 changed files with 1 additions and 1 deletions
|
@ -1427,7 +1427,7 @@ max3421_spi_thread(void *dev_id)
|
|||
* use spi_wr_buf().
|
||||
*/
|
||||
for (i = 0; i < ARRAY_SIZE(max3421_hcd->iopins); ++i) {
|
||||
u8 val = spi_rd8(hcd, MAX3421_REG_IOPINS1);
|
||||
u8 val = spi_rd8(hcd, MAX3421_REG_IOPINS1 + i);
|
||||
|
||||
val = ((val & 0xf0) |
|
||||
(max3421_hcd->iopins[i] & 0x0f));
|
||||
|
|
Loading…
Reference in a new issue