mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
i2c: xiic: fix reference leak when pm_runtime_get_sync fails
The PM reference count is not expected to be incremented on
return in xiic_xfer and xiic_i2c_remove.
However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.
Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.
Fixes: 10b17004a7
("i2c: xiic: Fix the clocking across bind unbind")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
parent
2c662660ce
commit
a85c5c7a3a
1 changed files with 2 additions and 2 deletions
|
@ -706,7 +706,7 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
|
|||
dev_dbg(adap->dev.parent, "%s entry SR: 0x%x\n", __func__,
|
||||
xiic_getreg8(i2c, XIIC_SR_REG_OFFSET));
|
||||
|
||||
err = pm_runtime_get_sync(i2c->dev);
|
||||
err = pm_runtime_resume_and_get(i2c->dev);
|
||||
if (err < 0)
|
||||
return err;
|
||||
|
||||
|
@ -873,7 +873,7 @@ static int xiic_i2c_remove(struct platform_device *pdev)
|
|||
/* remove adapter & data */
|
||||
i2c_del_adapter(&i2c->adap);
|
||||
|
||||
ret = pm_runtime_get_sync(i2c->dev);
|
||||
ret = pm_runtime_resume_and_get(i2c->dev);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
|
|
Loading…
Reference in a new issue