mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
eeprom: fix memory leak on buf when failed allocation of csraddr_str
The error return path When csraddr_str fails to free buf, causing a memory leak. Fix this by returning via the free_buf label that performs the necessary cleanup. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
3c84dc7e79
commit
acf50ec773
1 changed files with 4 additions and 2 deletions
|
@ -965,8 +965,10 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
|
||||||
csraddr_len = colon_ch - buf;
|
csraddr_len = colon_ch - buf;
|
||||||
csraddr_str =
|
csraddr_str =
|
||||||
kmalloc(sizeof(char)*(csraddr_len + 1), GFP_KERNEL);
|
kmalloc(sizeof(char)*(csraddr_len + 1), GFP_KERNEL);
|
||||||
if (csraddr_str == NULL)
|
if (csraddr_str == NULL) {
|
||||||
return -ENOMEM;
|
ret = -ENOMEM;
|
||||||
|
goto free_buf;
|
||||||
|
}
|
||||||
/* Copy the register address to the substring buffer */
|
/* Copy the register address to the substring buffer */
|
||||||
strncpy(csraddr_str, buf, csraddr_len);
|
strncpy(csraddr_str, buf, csraddr_len);
|
||||||
csraddr_str[csraddr_len] = '\0';
|
csraddr_str[csraddr_len] = '\0';
|
||||||
|
|
Loading…
Reference in a new issue