mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
ethtool: fec: add note about reuse of reserved
struct ethtool_fecparam::reserved can't be used in SET, because ethtool user space doesn't zero-initialize the structure. Make this clear. Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
f59798b8f6
commit
ad1cd7856d
1 changed files with 4 additions and 0 deletions
|
@ -1382,6 +1382,10 @@ struct ethtool_per_queue_op {
|
||||||
* @fec: Bitmask of configured FEC modes.
|
* @fec: Bitmask of configured FEC modes.
|
||||||
* @reserved: Reserved for future extensions, ignore on GET, write 0 for SET.
|
* @reserved: Reserved for future extensions, ignore on GET, write 0 for SET.
|
||||||
*
|
*
|
||||||
|
* Note that @reserved was never validated on input and ethtool user space
|
||||||
|
* left it uninitialized when calling SET. Hence going forward it can only be
|
||||||
|
* used to return a value to userspace with GET.
|
||||||
|
*
|
||||||
* FEC modes supported by the device can be read via %ETHTOOL_GLINKSETTINGS.
|
* FEC modes supported by the device can be read via %ETHTOOL_GLINKSETTINGS.
|
||||||
* FEC settings are configured by link autonegotiation whenever it's enabled.
|
* FEC settings are configured by link autonegotiation whenever it's enabled.
|
||||||
* With autoneg on %ETHTOOL_GFECPARAM can be used to read the current mode.
|
* With autoneg on %ETHTOOL_GFECPARAM can be used to read the current mode.
|
||||||
|
|
Loading…
Reference in a new issue