mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
ALSA: hda: add dev_dbg log when driver is not selected
On SKL+ Intel platforms, the driver selection is handled by the snd_intel_dspcfg, and when the HDaudio legacy driver is not selected, be it with the auto-selection or user preferences with a kernel parameter, the probe aborts with no logs, only a -ENODEV return value. Having no dmesg trace, even with dynamic debug enabled, makes support more complicated than it needs to be, and even experienced users can be fooled. A simple dev_dbg() trace solves this problem. BugLink: https://github.com/thesofproject/linux/issues/2330 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Link: https://lore.kernel.org/r/20200902154239.1440537-1-kai.vehmanen@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
13774d81f3
commit
ae03594716
1 changed files with 3 additions and 2 deletions
|
@ -2127,9 +2127,10 @@ static int azx_probe(struct pci_dev *pci,
|
||||||
*/
|
*/
|
||||||
if (dmic_detect) {
|
if (dmic_detect) {
|
||||||
err = snd_intel_dsp_driver_probe(pci);
|
err = snd_intel_dsp_driver_probe(pci);
|
||||||
if (err != SND_INTEL_DSP_DRIVER_ANY &&
|
if (err != SND_INTEL_DSP_DRIVER_ANY && err != SND_INTEL_DSP_DRIVER_LEGACY) {
|
||||||
err != SND_INTEL_DSP_DRIVER_LEGACY)
|
dev_dbg(&pci->dev, "HDAudio driver not selected, aborting probe\n");
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
dev_warn(&pci->dev, "dmic_detect option is deprecated, pass snd-intel-dspcfg.dsp_driver=1 option instead\n");
|
dev_warn(&pci->dev, "dmic_detect option is deprecated, pass snd-intel-dspcfg.dsp_driver=1 option instead\n");
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue