mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 14:44:12 +00:00
vdpa: check that offsets are within bounds
commit3ed21c1451
upstream. In this function "c->off" is a u32 and "size" is a long. On 64bit systems if "c->off" is greater than "size" then "size - c->off" is a negative and we always return -E2BIG. But on 32bit systems the subtraction is type promoted to a high positive u32 value and basically any "c->len" is accepted. Fixes:4c8cf31885
("vhost: introduce vDPA-based backend") Reported-by: Xie Yongji <xieyongji@bytedance.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20211208103337.GA4047@kili Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0c51663c77
commit
b08b3bfcc7
1 changed files with 1 additions and 1 deletions
|
@ -197,7 +197,7 @@ static int vhost_vdpa_config_validate(struct vhost_vdpa *v,
|
|||
struct vdpa_device *vdpa = v->vdpa;
|
||||
long size = vdpa->config->get_config_size(vdpa);
|
||||
|
||||
if (c->len == 0)
|
||||
if (c->len == 0 || c->off > size)
|
||||
return -EINVAL;
|
||||
|
||||
if (c->len > size - c->off)
|
||||
|
|
Loading…
Reference in a new issue