mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-15 15:15:47 +00:00
Code Issues Releases Wiki Activity

greybus: specify type when creating an operation

Browse source 
The type of an operation belongs in the operation header, which
shouldn't be touched by users of the interface.  So specify it
at operation creation time.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Alex Elder 2014-10-03 15:05:20 -05:00 committed by Greg Kroah-Hartman
parent 652433f3fe
commit b0b657555c
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/staging/greybus/operation.c
View file

@ -111,7 +111,7 @@ static void gbuf_out_callback(struct gbuf *gbuf)
* failure occurs due to memory exhaustion.
*/
struct gb_operation *gb_operation_create(struct gb_connection *connection,
size_t size)
size_t size, u8 type)
{
struct gb_operation *operation;
struct gb_operation_msg_hdr *header;
@ -139,8 +139,9 @@ struct gb_operation *gb_operation_create(struct gb_connection *connection,
/* Fill in the header structure and payload pointer */
operation->gbuf = gbuf;
header = (struct gb_operation_msg_hdr *)&gbuf->transfer_buffer;
header->id = 0;
header->size = cpu_to_le16(size);
header->id = 0; /* Filled in when submitted */
header->type = type;
operation->payload = (char *)header + sizeof(*header);
operation->callback = NULL; /* set at submit time */

2
drivers/staging/greybus/operation.h
View file

@ -60,7 +60,7 @@ struct gb_operation {
};
struct gb_operation *gb_operation_create(struct gb_connection *connection,
size_t size);
size_t size, u8 type);
void gb_operation_destroy(struct gb_operation *operation);
int gb_operation_wait(struct gb_operation *operation);