mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-21 00:10:09 +00:00
Code Issues Releases Wiki Activity

spi: sprd-adi: silence an uninitialized variable warning

Browse source 
If of_get_property() fails then "size" is uninitialized and it leads to
a static checker warning:

    drivers/spi/spi-sprd-adi.c:288 sprd_adi_hw_init()
    error: uninitialized symbol 'size'.

We can silence the warning by re-arranging the order of these checks.
It obviously doesn't affect runtime at all.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dan Carpenter 2017-09-22 23:48:08 +03:00 committed by Mark Brown
parent 04063a011f
commit b0d6e097b9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/spi/spi-sprd-adi.c
View file

@ -285,7 +285,7 @@ static void sprd_adi_hw_init(struct sprd_adi *sadi)
/* Set hardware channels setting */
list = of_get_property(np, "sprd,hw-channels", &size);
if (!size || !list) {
if (!list || !size) {
dev_info(sadi->dev, "no hw channels setting in node\n");
return;
}