mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
thermal: int3403_thermal: Fix NULL pointer deref on module load / probe
[ Upstream commit 13b86f50ea
]
Starting with kernel 4.17 thermal_cooling_device_register() will call the
get_max_state() op during register.
Since we deref priv->priv in int3403_get_max_state() this means we must
set priv->priv before calling thermal_cooling_device_register().
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
56dfe52e04
commit
b1d0907c6f
1 changed files with 1 additions and 2 deletions
|
@ -194,6 +194,7 @@ static int int3403_cdev_add(struct int3403_priv *priv)
|
|||
return -EFAULT;
|
||||
}
|
||||
|
||||
priv->priv = obj;
|
||||
obj->max_state = p->package.count - 1;
|
||||
obj->cdev =
|
||||
thermal_cooling_device_register(acpi_device_bid(priv->adev),
|
||||
|
@ -201,8 +202,6 @@ static int int3403_cdev_add(struct int3403_priv *priv)
|
|||
if (IS_ERR(obj->cdev))
|
||||
result = PTR_ERR(obj->cdev);
|
||||
|
||||
priv->priv = obj;
|
||||
|
||||
kfree(buf.pointer);
|
||||
/* TODO: add ACPI notification support */
|
||||
|
||||
|
|
Loading…
Reference in a new issue