mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 00:40:03 +00:00
video: fbdev: s3c-fb: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
parent
a644da2ec5
commit
b1d8c84abb
1 changed files with 5 additions and 6 deletions
|
@ -1392,18 +1392,17 @@ static int s3c_fb_probe(struct platform_device *pdev)
|
|||
spin_lock_init(&sfb->slock);
|
||||
|
||||
sfb->bus_clk = devm_clk_get(dev, "lcd");
|
||||
if (IS_ERR(sfb->bus_clk)) {
|
||||
dev_err(dev, "failed to get bus clock\n");
|
||||
return PTR_ERR(sfb->bus_clk);
|
||||
}
|
||||
if (IS_ERR(sfb->bus_clk))
|
||||
return dev_err_probe(dev, PTR_ERR(sfb->bus_clk),
|
||||
"failed to get bus clock\n");
|
||||
|
||||
clk_prepare_enable(sfb->bus_clk);
|
||||
|
||||
if (!sfb->variant.has_clksel) {
|
||||
sfb->lcd_clk = devm_clk_get(dev, "sclk_fimd");
|
||||
if (IS_ERR(sfb->lcd_clk)) {
|
||||
dev_err(dev, "failed to get lcd clock\n");
|
||||
ret = PTR_ERR(sfb->lcd_clk);
|
||||
ret = dev_err_probe(dev, PTR_ERR(sfb->lcd_clk),
|
||||
"failed to get lcd clock\n");
|
||||
goto err_bus_clk;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue