mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
iscsi-target: remove dead code in iscsi_check_valuelist_for_support
Neither "acceptor_values" nor "proposer_values" can be NULL here when scanning the value lists for incoming iSCSI login parameters such as HeaderDigest=CRC32C,None. Smatch complains because we are not allowed to pass NULL pointers to strchr(). Also I removed a second later check for "!acceptor_values" because it gets checked on the next line in the do while condition. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
8da10935bc
commit
b1e41d8cd4
1 changed files with 0 additions and 9 deletions
|
@ -1037,13 +1037,6 @@ static char *iscsi_check_valuelist_for_support(
|
|||
tmp2 = strchr(acceptor_values, ',');
|
||||
if (tmp2)
|
||||
*tmp2 = '\0';
|
||||
if (!acceptor_values || !proposer_values) {
|
||||
if (tmp1)
|
||||
*tmp1 = ',';
|
||||
if (tmp2)
|
||||
*tmp2 = ',';
|
||||
return NULL;
|
||||
}
|
||||
if (!strcmp(acceptor_values, proposer_values)) {
|
||||
if (tmp2)
|
||||
*tmp2 = ',';
|
||||
|
@ -1053,8 +1046,6 @@ static char *iscsi_check_valuelist_for_support(
|
|||
*tmp2++ = ',';
|
||||
|
||||
acceptor_values = tmp2;
|
||||
if (!acceptor_values)
|
||||
break;
|
||||
} while (acceptor_values);
|
||||
if (tmp1)
|
||||
*tmp1++ = ',';
|
||||
|
|
Loading…
Reference in a new issue