mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
staging: usbip: use DEVICE_ATTR_RO/RW for sysfs attributes
It's easier to audit the sysfs files if they use the RO/RW macros, so convert the usbip code to them. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
7322b320d6
commit
b1f56acaca
3 changed files with 11 additions and 10 deletions
|
@ -56,8 +56,8 @@ MODULE_DEVICE_TABLE(usb, stub_table);
|
|||
* usbip_status shows the status of usbip-host as long as this driver is bound
|
||||
* to the target device.
|
||||
*/
|
||||
static ssize_t show_status(struct device *dev, struct device_attribute *attr,
|
||||
char *buf)
|
||||
static ssize_t usbip_status_show(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
{
|
||||
struct stub_device *sdev = dev_get_drvdata(dev);
|
||||
int status;
|
||||
|
@ -73,7 +73,7 @@ static ssize_t show_status(struct device *dev, struct device_attribute *attr,
|
|||
|
||||
return snprintf(buf, PAGE_SIZE, "%d\n", status);
|
||||
}
|
||||
static DEVICE_ATTR(usbip_status, S_IRUGO, show_status, NULL);
|
||||
static DEVICE_ATTR_RO(usbip_status);
|
||||
|
||||
/*
|
||||
* usbip_sockfd gets a socket descriptor of an established TCP connection that
|
||||
|
|
|
@ -45,19 +45,20 @@ MODULE_PARM_DESC(usbip_debug_flag, "debug flags (defined in usbip_common.h)");
|
|||
struct device_attribute dev_attr_usbip_debug;
|
||||
EXPORT_SYMBOL_GPL(dev_attr_usbip_debug);
|
||||
|
||||
static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
|
||||
char *buf)
|
||||
static ssize_t usbip_debug_show(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
{
|
||||
return sprintf(buf, "%lx\n", usbip_debug_flag);
|
||||
}
|
||||
|
||||
static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
|
||||
const char *buf, size_t count)
|
||||
static ssize_t usbip_debug_store(struct device *dev,
|
||||
struct device_attribute *attr, const char *buf,
|
||||
size_t count)
|
||||
{
|
||||
sscanf(buf, "%lx", &usbip_debug_flag);
|
||||
return count;
|
||||
}
|
||||
DEVICE_ATTR(usbip_debug, (S_IRUGO | S_IWUSR), show_flag, store_flag);
|
||||
DEVICE_ATTR_RW(usbip_debug);
|
||||
|
||||
static void usbip_dump_buffer(char *buff, int bufflen)
|
||||
{
|
||||
|
|
|
@ -27,7 +27,7 @@
|
|||
/* TODO: refine locking ?*/
|
||||
|
||||
/* Sysfs entry to show port status */
|
||||
static ssize_t show_status(struct device *dev, struct device_attribute *attr,
|
||||
static ssize_t status_show(struct device *dev, struct device_attribute *attr,
|
||||
char *out)
|
||||
{
|
||||
char *s = out;
|
||||
|
@ -74,7 +74,7 @@ static ssize_t show_status(struct device *dev, struct device_attribute *attr,
|
|||
|
||||
return out - s;
|
||||
}
|
||||
static DEVICE_ATTR(status, S_IRUGO, show_status, NULL);
|
||||
static DEVICE_ATTR_RO(status);
|
||||
|
||||
/* Sysfs entry to shutdown a virtual connection */
|
||||
static int vhci_port_disconnect(__u32 rhport)
|
||||
|
|
Loading…
Reference in a new issue